On Thu, Mar 15, 2018 at 3:57 PM, Brad Jorsch (Anomie) <bjorsch(a)wikimedia.org
wrote:
PHP7's expectations seem like they started fixing those issues, although
eval()-like use is still an option and exception-throwing seems to not be
the default.
indeed I must admit that it's rather concerning that assert( 'code' ) will
try to evaluate the string arg
and I completely overlooked this. I was focused on the perf arguments.
But what I understood from discussion is that even if PHP resolves these
issues in the future
it's unlikely that we will disable assertions in production mode for WMF
appservers.
So assert() will never be an option for performance hotspots.
Thanks for your feedback!