<quote name="Jon Robson" date="2016-05-12" time="17:56:24 -0700">
. On 12 May 2016 4:18 p.m., "Stas Malyshev" smalyshev@wikimedia.org wrote:
Hi!
No, -2 is restricted to project owners and thus not an op- tion for the vast majority of contributors. For that pur- pose, I proposed a Gerrit label "WIP" (cf.
http://permalink.gmane.org/gmane.science.linguistics.wikipedia.technical/840... ).
This looks like a nice solution.
Seconded. What's stopping us from adopting? It seems in that thread nothing happened.
Greg - is this something we can do?
Certainly.
"Adopting"? :) Making it official? I'd guess just setting the Gerrit config to exposing the WIP label and then documenting it on mw.org, maybe one of: * https://www.mediawiki.org/wiki/Gerrit/Advanced_usage * https://www.mediawiki.org/wiki/Gerrit/Code_review (only focused on the review part, not the submission part, should it expand in scope?) * https://www.mediawiki.org/wiki/Gerrit/Getting_started ? maybe too basic/focused to have this? * Maybe a new page describing the stages of a change and how to start contributing? I think of this because of this task:https://phabricator.wikimedia.org/T73357 - "Add a welcome bot to Gerrit for first time contributors"
Task to track this for Gerrit I've created: https://phabricator.wikimedia.org/T135245
(Below is just some documentation on how to do it that I wrote last night...)
How to do it via the command line?
For Gerrit, use what was proposed in that last thread by Tim L:
<quote name="Tim Landscheidt" date="2015-09-14" time="21:07:47 +0000">
"C. Scott Ananian" cananian@wikimedia.org wrote:
I'd use this tag more often if I could set it from the gerrit command-line when I upload a patch. Otherwise it will be pretty inconvenient to keep this in sync with the summary line of my patch.
That should be possible with Gerrit's command line inter- face (cf. https://gerrit-review.googlesource.com/Documentation/cmd-review.html). For example, I just voted on https://gerrit.wikimedia.org/r/#/c/238201/ with:
| ssh -p 29418 gerrit.wikimedia.org gerrit review --label Code-Review=+1 4266a950bf7d0984cc5177b0f2f8d76b7d0b3c55
This /should/ work for arbitrary labels.
For those experimenting with Differential already it's even easier per Mukunda:
<quote name="Mukunda Modell" date="2016-05-12" time="17:19:06 -0500">
We definitely need consistency for any convention like this to be useful. Phabricator has the equivalent of self-2 in Differential: `arc diff --plan-changes`
From arcanist's help information:
greg@x230 ~ % arc help diff <snip> --plan-changes Create or update a revision without requesting a code review. <snip>
Which makes something like this: https://secure.phabricator.com/D15906
Then that change does not show up in searches for Diffs needing review. :)
Best,
Greg