dinar qurbanov <qdinar(a)gmail.com> wrote:
> How would it help the reviewer if they constantly
need to
> switch their mind from "prettified" code to "whatever" when
> they review your code?
it is possible to show prettified code in gerrit web
pages, and send
prettified version to people if they get it via git fetch, but save
also their original form .
and, as another alternative, it is possible to save
original form in
author's computer, and automatically prettify it in gerrit server just
after he pushes it into gerrit...
> If you don't want to press the space bar, you
can always in-
> tegrate stylize
> (
>
http://git.wikimedia.org/blob/mediawiki%2Ftools%2Fcode-utils.git/master/sty…
> )
> in your workflow or amend your editor to insert the spaces
> when you type.
then i would need to see that prettified code at my
further local
editions and sometimes i would have to manually delete that extra
spaces during editing my code.
[...]
You could also amend your editor to do those deletions for
you, but I think there is a fundamental misunderstanding
here: MediaWiki is a collaborative project. If you think in
categories like "author" and "my" or "your" code, you will
be disappointed.
MediaWiki uses a very spacey coding style, other PHP
projects do not. Even though the syntax is /very/ similar,
most C, JavaScript, Perl, PHP, etc. projects use different
conventions. So: When in Rome, do as the Romans do. Every-
thing else does not work in practice.
Tim