On 01/13/2015 09:08 AM, Bryan Davis wrote:
On Tue, Jan 13, 2015 at 7:40 AM, Tyler Romeo tylerromeo@gmail.com wrote:
I know we just added some new maintenance scripts for checking things with composer. I’m sure it wouldn’t be that bad having update.php check first and tell the user to run “composer install” before doing update.php.
Kunal made the new "checkComposerLockUpToDate.php" maintenance script to validate $IP/vendor against the $IP/composer.json file. An end user could either add this to their typical workflow before running update.php or we could try to find a reasonable way to integrate the check it performs into the update script. Checking for external dependencies isn't the same thing at all as updating a database schema so I'd lean towards suggesting that the new script be used separately.
I tried getting update.php to run checkComposerLockUpToDate.php but it was messy and didn't really work well, so I uploaded a patch[1] that adjusts the intro text to recommend that you run checkComposerLockUpToDate.php before running update.php.
[1] https://gerrit.wikimedia.org/r/#/c/185592/
-- Legoktm