On Thu, Mar 6, 2014 at 8:29 PM, Tyler Romeo tylerromeo@gmail.com wrote:
- not everybody is subscribed to mobile-l, so you cannot expect the
original reviewers to see or know about it 2) this is an issue with MobileFrontend, not MediaWiki core 3) code being merged does not automatically cause a deployment, and if code being deployed breaks something in production, it is the operations team's job to undeploy that change
If your patch causes a serious UX regression like this, it's going to get reverted. The core patch involved was being deployed to Wikimedia sites / impacting MobileFrontEnd users today. If we had more time in the deployment cycle to wait and the revert was a simple disagreement, then waiting would be appropriate. It is obvious in this case no one tested the core change on mobile. That's unacceptable.
And yes, Jon should have made sure the revert and the original patch were cross-referenced. I'm sure he'll do that next time he commits a revert.
Steven