On Thu, Jan 9, 2014 at 6:28 AM, Jeroen De Dauw jeroendedauw@gmail.comwrote:
Hey,
Some suggestions regarding code quality and design:
- The MediaWiki SpecialPage system has serious design issues and is best
treated as legacy API. I recommend not binding domain or application logic to it where this can be avoided. This means not having most code in a subclass of SpecialPage.
I agree that you shouldn't have much logic in the SpecialPage subclass, as that class is very high-level and meant for showing the output and handling of input. All *real* work should be delegated elsewhere.
I don't think it's a legacy API at all--it's certainly better than the mess of Action classes (not that we couldn't clean it up a bit, but I digress) What alternative would you propose for people to use? Implementing a content handler?
-Chad