On 08/08/14 14:24, Jon Robson wrote:
On 8 Aug 2014 04:23, "Antoine Musso" hashar+wmf@free.fr wrote:
Le 07/08/2014 22:05, Erwin Dokter a écrit :
I now have to submit two patches and hope they both get merged at the exact same time.
The world we should be working towards is one where you'd only have to update the skin. Moving this code out of core I believe will help drive that. Submitting two patches _is_ annoying and this is why I think it will drive improvements to the skin API. :)
This. If it takes two patches, one in the skin, one in core, this seems like a good thing - because then it means the added support will then be available to all the other skins too, including mobile and the skins of various other projects. This is important, because it also means that it should become easier to not just focus on a single skin and ignore everything else (which has long been the case with vector).
While this should be great for third-party projects, even around here, users of monobook who've seen new features released that simply not work on their skin should also benefit, as well as potentially everyone else as well should the time come for a new default skin for Wikimedia, something that will have to happen sooner or later.
-I