John, switching to extension based skins would have resulted in this EXACT same scenario. Since the only difference here is that the skins are in skins/ instead of extensions/. In both cases the vanilla core git repo would not have the skin checked out and you would still have to clone it in exactly the same way.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/]
On 2014-08-07, 12:30 PM, John wrote:
Actually Im not making personal attacks. I am pointing out the flawed process that is being/was implemented. What should have happened was that skins are migrated to extensions and use the existing structure. Doing that would require a lot of work, and a fairly major overhaul of the existing code. Because that is too much work/too complex/users want to take the "easy" way out the current process was used.
Doing something this critical half baked, which was specifically raised before and ignored, is a BAD idea. I know quite a few users who use GIT checkouts for their wikis. Guess what? this change will screw all of them and be a pain in the ass to fix and maintain such forking. Moving to an extension based system is the correct, logical and long term best solution. But you know what? it wont happen, instead skins will fork into a spaghetti code system that stifles users who want custom skins and causes a LOT more regression/bugs due to divergent code bases.
Ill repeat what I said (knowing it will probably be ignored) If your going to overhaul the skin system do it right and merge them into the existing extension framework dont re-invent the wheel and add more overhead to an already complex system.
On Thu, Aug 7, 2014 at 3:12 PM, James HK jamesin.hongkong.1@gmail.com wrote:
Hi,
And James, what is your problem? Try running a current MW with the LocalSettings.php from - I don't know - MW 1.16 or something. You expect that to work? Really?
Honestly, I don't care about skins, when I download MW I'd expect it to work and not to figure out that I need another two, three or four steps just to have decent user experience.
I want my LocalSettings from MW 1.23 to work with MW 1.24 (we are not talking about an ancient release such as 1.16) without having to study an extra page on mw.org about skins.
Cheers
On 8/8/14, Stephan Gambke s7eph4n@gmail.com wrote:
I consider it rather bad style to launch personal attacks in what should be a technical discussion. In particular when your own arguments basically amounted to a statement that having to execute some git command would be "a pain in the ass". It was to be expected, that there would be some snags. Crying "I told you so" is somewhat less than constructive. I am sure Bartosz is already working on it.
And James, what is your problem? Try running a current MW with the LocalSettings.php from - I don't know - MW 1.16 or something. You expect that to work? Really?
Maybe everybody could cool down a bit and keep thing on a non-personal level? I'd appreciate it.
On 7 August 2014 18:18, John phoenixoverride@gmail.com wrote:
Exactly what I warned about. Yet another example of poor thinking/execution and exactly what I predicted.
On Thu, Aug 7, 2014 at 12:02 PM, James HK <jamesin.hongkong.1@gmail.com wrote:
Hi,
I just went on to `git pull --rebase origin master` on getting MW 1.24 master and suddenly I see a "Whoops! The default skin for your wiki ($wgDefaultSkin), vector, is not available."
I have to say that I'm not really interested in modifying the LocalSettings.php just to get a MW working as it used to be.
I do expect when downloading MW it is at least functional and not comes with a message of "Whoops!" your missing something.
The other funny thing, is the message which says: "You can paste the following lines into LocalSettings.php to enable all currently installed skins:" ( empty )
So I should paste an empty message to `LocalSettings.php`, what the hell!!
If you at least provide a composer download for the standard skins, I could go on and do `composer mediawiki/vector-skin` without having the remember the location of some gerrit repo, doing some cryptic git submodule stuff or care about "mediawiki/skins/*" at all.
Cheers
On 8/7/14, Bartosz Dziewoński matma.rex@gmail.com wrote:
This has just happened.
The instructions MediaWiki will display should guide you through.
Poke
me on IRC if the email I send earlier and the instructions don't help :)
-- Matma Rex
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l