No. I've thought the OpenStack policy is rude to contributors.
If your personal review queues are too spammy you should be more aggressive about removing *yourself* from the change.
-Chad
-Chad On Apr 9, 2014 8:08 AM, "Quim Gil" qgil@wikimedia.org wrote:
In relation to our discussion about code review metrics at http://korma.wmflabs.org/browser/gerrit_review_queue.html
I just learned that OpenStack has a policy to abandon automatically reviews sitting in -1 during more than one week:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63533#c1
Maybe one week is too tight for the reality of our project, but what about 2-4 weeks?
Brad and others said last week that they were not interested in code review queue metrics mixing pending -1 reviews. Maybe the solution is not to tweak the metrics, but to effectively abandon those changesets automatically?
-- Quim Gil Engineering Community Manager @ Wikimedia Foundation http://www.mediawiki.org/wiki/User:Qgil _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l