Le 09/04/2014 17:08, Quim Gil a écrit :
In relation to our discussion about code review metrics at http://korma.wmflabs.org/browser/gerrit_review_queue.html
I just learned that OpenStack has a policy to abandon automatically reviews sitting in -1 during more than one week:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63533#c1
Maybe one week is too tight for the reality of our project, but what about 2-4 weeks?
Hello,
I am fine having changes abandoned automatically after a couple weeks. Just make sure registered users are allowed to restore changes though.
My questions for the general audience are why we do keep those patches around.
Are we expecting the author to somehow come back, look at their Gerrit dashboard and resume it? Thus letting patch open as a convenience.
Are we expecting someone else to take over the patch and complete it? The inactive patches could thus been seen as a list of features to have, but then we have Bugzilla for that :]
So yeah, dropping automatically seems fine to me.