I have some changesets where I uploaded a reworked patchset several weeks
or even months after an original -1 was given...
Anyway a changeset can be easily "renewed" by rebasing it, but the side
effect is that all existing -1's get flushed. If people start to use this
method to extend the period, it's not something good...
On Wed, Apr 9, 2014 at 11:25 PM, Jon Robson <jdlrobson(a)gmail.com> wrote:
Yes yes yes please!
I've been manually doing this in mobile with a short friendly note saying
if the owner wants to resubmit it they can feel free to at a later date. My
gerrit is just a spam queue right now.
Just to clarify - if someone submits a patch then says 1 month later via
comment I still want to work on it do we abandon it for the time being or
keep it open?
On 9 Apr 2014 08:08, "Quim Gil" <qgil(a)wikimedia.org> wrote:
In relation to our discussion about code review
metrics at
http://korma.wmflabs.org/browser/gerrit_review_queue.html
I just learned that OpenStack has a policy to abandon automatically
reviews
sitting in -1 during more than one week:
https://bugzilla.wikimedia.org/show_bug.cgi?id=63533#c1
Maybe one week is too tight for the reality of our project, but what
about
2-4 weeks?
Brad and others said last week that they were not interested in code
review
queue metrics mixing pending -1 reviews. Maybe
the solution is not to
tweak
the metrics, but to effectively abandon those
changesets automatically?
--
Quim Gil
Engineering Community Manager @ Wikimedia Foundation
http://www.mediawiki.org/wiki/User:Qgil
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l