On Mon, 20 May 2013 12:45:32 -0700, Bartosz DziewoĆski matma.rex@gmail.com wrote:
On Mon, 20 May 2013 19:51:50 +0200, Daniel Friesen daniel@nadir-seen-fire.com wrote:
// @todo FIXME: This causes breakage in various places when we // actually expected a local URL and end up with dupe prefixes. if ( $wgRequest->getVal( 'action' ) == 'render' ) { $url = $wgServer . $url; }
That TODO has been there since 2006 (r12621), so apparently it doesn't cause that much breakage if nobody bothered to fix it.
Breakage is fairly irrelevant. It's a hack using global context sitting directly inside of our fundamental Title class. Breakage or no breakage, we don't support hacks forever. ;) sounds like this hack is stretching it's lifespan pretty thin.