On Tue, Jul 23, 2013 at 12:19 PM, Ori Livneh ori@wikimedia.org wrote:
Daniel was diligent about adding wfDeprecated calls to the deprecated methods that the older hooks calls. I wonder if we could add a Jenkins check that flags usage of deprecated features. A sophisticated version would trace the execution of unit tests and flag diffs that activate deprecated code paths. But for starters we could just have a non-voting Jenkins job that greps diffs for deprecated hook names.
I see now that setting $wgDevelopmentWarnings = true will manifest usage of deprecated methods in PHP's error log, with E_USER_DEPRECATED. Jenkins could keep track of the number of these that are emitted by test runs and -1 changes that caused the number to go up.
I'll do my bit by enable this setting on MediaWiki-Vagrant :)
Ori