On 18 jul. 2013, at 00:25, Jon Robson jdlrobson@gmail.com wrote:
On Wed, Jul 17, 2013 at 3:22 PM, Derk-Jan Hartman d.j.hartman+wmf_ml@gmail.com wrote:
"If people don't want to put their code through review this is scary to me"
They do get their code reviewed. The rules are however usually simple 'it needs to work'. Not everyone has time to spend a gazillion hours on getting familiar with git, gerrit, jshint, git-review, resourceloader, i18n, l10n, the actual review lag, the deploy lag and I don't know what else.
Some ppl just want to edit categories super fast NOW. That's how these tools start and then these people are usually done. A bit of required maintenance, but that's it, they are editing/reviewing/categorizing again. Look at navpopups. With minor changes, that thing has been able to run basically unsupervised since 2006 and it is one of the most popular tools.
This seems like a bad habit to have got ourselves into... All it takes is a trailing comma somewhere and a gadget could take out a whole browser. Likewise a bad usage of a css transition can completely kill site performance and make everything laggy. I'm not disagreeing that this workflow gets results - it obviously does - but I think we should be striving to identify good Gadgets and giving them love and attention for the good of everyone.
Like I said, I just don't think that Extensions and our current Developer workflow are a good fit for that love and attention.
DJ