On Thu, Sep 20, 2012 at 3:42 PM, Mark Holmquist mtraceur@member.fsf.org wrote:
- Changes and rebases are combined.
It should be said, this is part of the recent "five tips to get your code reviewed faster". You should never combine a rebase with an actual substantial change, because it makes it very hard to compare between patchsets. (I didn't see this in the "quick tips" list, thought I should mention it)
And if you can, try to use the "rebase" button as much as possible!
Couple of changes coming in Gerrit upstream that will make this better: - Gerrit won't perform the rebase if it's not necessary - Changes as a result of a rebase aren't shown in the changes list when comparing to an old patchset
I believe the former made it into 2.5 (need to double check). Pretty sure the latter didn't, unfortunately.
-Chad