Oops, I just backported a bugfix from jQuery's development trunk to MW a
few weeks ago. It involved an obvious bug in a core jQuery function that
was causing a bug in MW 1.19. The only alternatives were to locally patch
some jQuery plug-ins or live with the weird behavior, so either way we were
screwed. I would say in general we should avoid this, but I imagine there
are circumstances where the cost of waiting outweighs the cost of not being
on a clean release.
Ryan Kaldari
On Fri, Mar 30, 2012 at 6:30 AM, Krinkle <krinklemail(a)gmail.com> wrote:
On Mar 30, 2012, at 10:14 AM, Amir E. Aharoni wrote:
Hi,
I made a little localization fix to the jQuery.ui datepicker, which is
used by the Upload Wizard. I submitted it upstream through GitHub and
it was merged there.
Krinkle says that jQuery is supposed to be only modified upstream, and
that is a Good Thing. What is our policy for actually merging upstream
jQuery changes to MW code?
I wouldn't go as far as calling it a policy, but I'd recommend we don't do
merging of any kind with upstream libraries.
Only update to official (minor or major) releases.
So next time they release, we update the copy in master and from there we
make sure things are still compatible and the unit tests pass.
If they consider it an important fix, they'll make a minor release soon,
and else we'll have wait for them to release.
If they refuse to release (or if the maintainer isn't active anymore), then
we could consider forking it entirely and merging our proposed upstream
fixed to master ahead of time (like we did with the jQuery Tipsy plugin),
but
fortunately that isn't a concern for jQuery UI :)
-- Krinkle
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l