2012/3/29 Chad innocentkiller@gmail.com:
On Wed, Mar 28, 2012 at 2:05 PM, Rob Moen rmoen@wikimedia.org wrote:
I agree. Having 'you' or 'i' makes the message personal when the focus should remain on the commit itself.
- 1
This patch needs improvement. | Needs improvement, this patch does. ( if we go with the yoda job )
I've combined a little bit of everyone's suggestions so far (other than Yoda).
How does "There is a problem with this patchset, please fix" sound?
Better: please fix it.
Or: please improve it.
-- Amir Elisha Aharoni · אָמִיר אֱלִישָׁע אַהֲרוֹנִי http://aharoni.wordpress.com “We're living in pieces, I want to live in peace.” – T. Moore