I agree. Having 'you' or 'i' makes the message personal when the focus should remain on the commit itself.
+ 1 This patch needs improvement. | Needs improvement, this patch does. ( if we go with the yoda job )
On Wed, Mar 28, 2012 at 8:29 AM, Antoine Musso hashar+wmf@free.fr wrote:
Le 28/03/12 15:10, Chad a écrit :
There's been some comments that the phrasing for a -1 vote in Gerrit ("I'd prefer that you didn't submit this") is kind of personal and we can do better.
Better as make it even more personal ? :-D
My suggestion is:
"This patchset needs to be improved"
That sounds positive to me. At least improving something is probably more of a reward than fixme.
Sometime, we might have a patch which is fine to merge but not perfect yet, so I guess that case is covered by my suggestion.
A fun one would be:
"Much to learn you still have...my old padawan."
Would probably make a Yoda job in Jenkins just for that :-D
-- Antoine "hashar" Musso
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l