2012/3/25 Amir E. Aharoni amir.aharoni@mail.huji.ac.il:
Hi,
There's something in Gerrit that i still don't get, even after trying to ask this several times on mediawiki.org [1] and on IRC. I sincerely thank everyone who took the time to reply, but either i still misunderstand the replies or i do understand them and I Just Don't Like It [2].
Let's consider a patch set i submitted: https://gerrit.wikimedia.org/r/#change,3361 .
The patch set as i submitted it was not perfect and Aaron marked it "-1". So far, so good. Then Hashar amended the patch set and Nikerabbit amended it some more.
... Now that i look at that patch again, i realize that there were no code changes by Nikerabbit - only inline code comments. That confusion was probably caused by Gerrit's UI, with which many people already expressed dissatisfaction, but that's a separate issue.
My main claim still applies - it would make more sense to see every stage in the development of this patch as a separate commit. I tried to play with the "Old Version History" dropdown, which looked like it can help making it easier, but it only added more confusion.
-- Amir