On Sat, Feb 11, 2012 at 4:46 PM, Ryan Lane rlane32@gmail.com wrote:
On Fri, Feb 10, 2012 at 5:08 AM, John Du Hart compwhizii@gmail.com wrote:
Unless you've been living under a rock (If you have, how's the wifi under there?) we're moving to git soon. Along with this will come a change in
how
we do code review. However, some people have expressed concerns over the usability of gerrit. Therefore I'd like to propose an alternative.
Phabricator is a code review tool written by and for Facebook that has been open sourced. For an introduction, see this: http://phabricator.com/docs/phabricator/article/Introduction.html
I've written up some documentation about Phabricator for our uses here: https://www.mediawiki.org/wiki/Phabricator
I would really like for some of our developers and reviewers to try this out as an alternative to gerrit. Personally I've found it much more pleasurable to work with than gerrit. If we think this might be a viable solution for us then I'd be willing to work on adding more integration (LDAP support and Unit testing integration).
Let me know if you have any questions or feedback. Thanks!
I forgot. There's one other thing I wanted to point out about phabricator. To properly use it, you must have php installed wherever you are working from. I like that it uses PHP on the server side, but despise that it uses it on the client side.
I also have a few questions:
- Who's going to get stuck with maintaining the LDAP support?
- Does it already integrate with Jenkins?
- Does it use the system SSH, or a separate SSH daemon?
- What permissions model does it have?
- Does it manage the repositories and branches?
- How are repos created?
- Does it support server side branches?
- Does it handle merges automatically?
- Ryan
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
* Me * Why would it need to, it runs unit and lint tests before the diff is posted
The rest of the questions are irrelevant because, unlike gerrit, Phabricator does not manage git repositories.