On Wed, Dec 12, 2012 at 1:46 PM, Ryan Kaldari rkaldari@wikimedia.org wrote:
On 12/12/12 4:44 AM, Chad wrote:
On Wed, Dec 12, 2012 at 3:09 AM, Ryan Kaldari rkaldari@wikimedia.org wrote:
I found a solution to the problem: If a gerrit administrator declares the mimetypes of the files to be safe they will be displayed in-browser rather than downloaded as zip files:
https://gerrit-review.googlesource.com/Documentation/config-gerrit.html#_a_i...
Could someone edit the gerrit.config file to declare php, javascript, and css files as 'safe'?
That doesn't quite work the way you're thinking--it's for us to define mimetypes that Gerrit should show diffs of (rather than a zip download of the file). All text- based filetypes are already shown by the browser as diffs, but most binary filetypes aren't shown on diff. Images originally suffered this problem, but we fixed it[0].
There's not a config switch for what the OP is asking for--but feel free to file a bug upstream[1] :)
Are you sure? This doesn't jibe with what the Gerrit developers say in the support forums: https://groups.google.com/forum/#!topic/repo-discuss/h7Bvgns5cyY/discussion
Yes, I'm pretty sure. That thread is confusing.
Before we enabled this for images, you used to have to download images as a zip rather than in diffs. I'm pretty sure it has no affect on the "download" buttons serving zips on those pages...but we can test.
See bug 36852[0] for history. Also fun is which mimetypes to use[1] ;-)
-Chad
[0] https://bugzilla.wikimedia.org/show_bug.cgi?id=36852 [1] http://cweiske.de/tagebuch/php-mimetype.htm