On Fri, Dec 7, 2012 at 9:29 AM, Andre Klapper aklapper@wikimedia.org wrote:
On Wed, 2012-12-05 at 00:29 +0100, Andre Klapper wrote:
On Tue, 2012-12-04 at 14:53 -0500, Chad wrote:
On Tue, Dec 4, 2012 at 2:44 PM, Andre Klapper aklapper@wikimedia.org wrote:
The only (potential) regression is that we did not apply previous changes to Bugmail.pm, described as "Wikimedia Hack! Pretend global watchers are CCs so we can use their prefs to for instance ignore CC-only mails."
Is there a reason for this? We had this hack in place to keep BZ from spamming IRC/wikibugs-l when only the CC list changes...
So the aim of the patch was to completely omit bugmail in case of CC list only changes, in order to make IRC + wikibugs-l@ less noisy?
- I assume this silently broke "The CC field changes" settings on
https://bugzilla.wikimedia.org/userprefs.cgi?tab=email for everybody in the past. "Assume" because my time machine back to 4.0.9 is broken. 2) wikibugs-l@ is also set as "globalwatchers" ("who should receive a copy of every notification mail Bugzilla sends"). After the Bugzilla upgrade wikibugs-l@ *finally* works reliably for me and seems to send ALL bugmail. Before I didn't receive bugmail anymore after wikibugs-l@ got removed as assignee of a report && when wikibugs-l@ was not listed either as default CC of the corresponding component (test example: bug 42226).
I don't know how your preferences were configured, but our hack has worked as expected for years. The logic only happens to @watchers[0], and all it does is set the default CC param for the global watch user. No actual user preferences should be changed.
-Chad
[0] https://gerrit.wikimedia.org/r/gitweb?p=wikimedia/bugzilla/modifications.git...