On Wed, 2012-12-05 at 00:29 +0100, Andre Klapper wrote:
On Tue, 2012-12-04 at 14:53 -0500, Chad wrote:
On Tue, Dec 4, 2012 at 2:44 PM, Andre Klapper aklapper@wikimedia.org wrote:
The only (potential) regression is that we did not apply previous changes to Bugmail.pm, described as "Wikimedia Hack! Pretend global watchers are CCs so we can use their prefs to for instance ignore CC-only mails."
Is there a reason for this? We had this hack in place to keep BZ from spamming IRC/wikibugs-l when only the CC list changes...
So the aim of the patch was to completely omit bugmail in case of CC list only changes, in order to make IRC + wikibugs-l@ less noisy?
1) I assume this silently broke "The CC field changes" settings on https://bugzilla.wikimedia.org/userprefs.cgi?tab=email for everybody in the past. "Assume" because my time machine back to 4.0.9 is broken. 2) wikibugs-l@ is also set as "globalwatchers" ("who should receive a copy of every notification mail Bugzilla sends"). After the Bugzilla upgrade wikibugs-l@ *finally* works reliably for me and seems to send ALL bugmail. Before I didn't receive bugmail anymore after wikibugs-l@ got removed as assignee of a report && when wikibugs-l@ was not listed either as default CC of the corresponding component (test example: bug 42226).
These might be related [or not] to dropping the hack.
In any case, I'd like to challenge reapplying this patch, because:
1) Don't set wikibugs-l@ as globalwatchers if you don't want it to receive all bugmail about all changes. 2) If you want a certain account to not receive email in case of changing X in Bugzilla, edit the accounts's "when to send mail" settings in Bugzilla to not to send bugmail in case of only changing X. Obviously this interferes with 1) currently.
andre