If the 'browser' option is set to true, it's supposed to automatically accept globals like window and document without having to explicitly exempt them. Not sure why that isn't working on Jenkins, though.
Ryan Kaldari
On 12/5/12 10:57 AM, Jon Robson wrote:
Are you setting this as a global variable? I had the same issue and realised it needed to be defined as an option
See https://gerrit.wikimedia.org/r/#/c/36919/3/.jshintrc for reference.
On Wed, Dec 5, 2012 at 10:51 AM, Ryan Kaldari rkaldari@wikimedia.org wrote:
That's weird, it looks like browser is already set to true in .jshintrc, but I still get errors for window being undefined from Jenkins. Is Jenkins using the .jshintrc file?
Ryan Kaldari
On 12/5/12 10:48 AM, Ryan Kaldari wrote:
Can we set 'browser: true' in the jshint config so that it won't complain about window being undefined?
Ryan Kaldari
On 12/5/12 10:16 AM, Jon Robson wrote:
Thanks Antoine! Currently JSHint doesn't get a vote on MobileFrontend
(http://integration.mediawiki.org/ci/job/mwext-MobileFrontend-jslint/10/conso... : SUCCESS (non-voting)). Is it possible to make it vote and -1 anything which disobeys jshint? This would be extremely useful.
I'm really excited by this, and I'm looking forward to qunit integration next ;)
On Wed, Dec 5, 2012 at 2:52 AM, Antoine Musso hashar+wmf@free.fr wrote:
Le 04/12/12 22:22, Jon Robson a écrit :
This is now running on MobileFrontend [1] but needs some tweaking! It's awesome! Kudos to whoever enabled that.
<snip> > [1] > https://integration.mediawiki.org/ci/job/mwext-MobileFrontend-jslint/6/console Hello Jon,
I did enable it but most of the credits come to Timo who packaged JSHint so it can be used by Jenkins :-]
That is still a bit a work in progress though, JSHint results are not being shown in Jenkins yet beside the console output.
-- Antoine "hashar" Musso
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l