Le 23/08/12 10:44, Niklas Laxström a écrit :
I'm doing a lot of code review[1], but I feel like it's wasting my time by being inefficient. I'm still looking forward to diffs in emails and/or one page diff view in Gerrit. Especially re-reviewing big patches is just plain annoying when you have to go over all files just to find the changes.
I review big patches by fetching the change from the repository and using my local diff tool. Of course you need to use the Gerrit diff system to add inline comments.
My dashboard is mostly useless, it's full of -1 or +1 patches waiting for an action by the submitter. Or +0 patches I gave +1 or -1 before new patchset was submitted - they are indistinguishable from totally new patches. It would also be nice to have different queues for things like GSoC, Translate, sprint related, i18n review requested.
I am pretty sure Gerrit will come with saved search in the future. Chad will be able to confirm. As for the dashboard, just take care about lines which have no score from you (they should be bold) and do the -1 +1 score. Ignore the rest. If a patch was reset to +0, then it needs to be reviewed again by you (most probably a trivial review).
It has also happened that my inline comments have been ignored because a new patchset was submitted without addressing them, and subsequent reviewers didn't notice the comments anymore.
It happened to me a few time to. One feature that could be able to Gerrit would be to prevent submitting a change till all inline comments have been replied to and marked as closed/fixed.
<snip>