On 22.08.2012 15:56, Daniel Friesen wrote:
Where is the discussion and review of ContentHandler?
There is not much discussion going on. There's a slowish conversation I'm having with Tim on Bugzilla:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=shortlog;h=re...
There's also a few changes pending on Gerrit:
https://gerrit.wikimedia.org/r/#/q/project:mediawiki/core+branch:Wikidata+is...
I'd like to comment and review some part of the code. Like method naming patterns that don't match the patterns we use elsewhere in core. And coding patterns/assumptions that don't seem to leave room for some of the rationales ContentHandler was created for.
Yes, please! At the moment, the best place for this is probably bugzilla.
But the ContentHandler code is spread out over many pre-accepted commits, and that that it's not even part of a dedicated branch so it's hard to find the relevant commits amongst the pile of Wikidata commits.
Here's the dedicated branch:
https://gerrit.wikimedia.org/r/gitweb?p=mediawiki%2Fcore.git;a=shortlog;h=re...
Of course, I keep merging the latest master into it, so you'll see a lot of unrelated commits. Just look for the ones by me :) Or just diff the branch against current master.
(This would be nicer if I had used rebase from the beginning instead of merging master into the Wikidata branch - sadly, this branch started on SVN).
-- daniel