Hey,
Every time someone asks for specifics ("where is this
code used?", "what exactly is this needed for?"), they get very meta answers ("it's used in Wikidata").
Can you be specific and point to these questions we've answered to vague, then I'll try to answer then in more detail.
If you want to expedite this review, give specific answers. Point to
line numbers in files, and show how the code there would be far more complicated without this change. Point to specific functionality we can see in a running instance. Use this as an opportunity to educate everyone on Wikidata internals.
We need generalizations provided by this patch. Yes, that's not specific at all to why and where we need them. You'd need to know that to verify we're not doing stupid stuff in Wikidata. However, these generalizations make sense on their own, and can be judged entirely loose from Wikidata. Educating people on Wikidata internals really seems to be out of scope to me.
I don't think enough people actually understand the patch well enough
to say that.
The code is well documented and I've been answering questions both on the list here and gerrit. If you want to understand the patch, look at it, and if you're still not clear on anything, ask about it. I don't see how we can do much more from our end - got any suggestions?
The fear is that it's a step sideways, trading crufty
but well-tested code for something larger, more confusing, and less stable.
How do you figure this? My interpretation from the thread is similar to that of Denny - we're basically all agreeing that this change improves on the current system in various ways, but some thing it should tackle some issues it's not currently dealing with as well.
Cheers
-- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. --