I think it would be about time to start practicing what we preach (like, that MW is a great knowlagebase tool) and move all these comments to mw.org database manual pages. It's handy to have all those comments in the code, but to clutter the schema abstraction code over those comments is just silly.
LP, Jure
On 23. 04. 2012 00:36, Greg Sabino Mullane wrote:
Platonides wrote:
Note we will also need a way to generate a SQL from that (eg. for manually creating a new database with SQLAdmin).
Personally, I prefer viewing the code (SQL) which is really used, but I won't stop you from making the perfect abstraction.
Well, the very first task of the new system will be to generate a tables.sql and make sure it matches the current one. Perhaps we can even keep them around, but make them "read only", for the benefit of circumstances like the above (as well as making it easy to read from the perspective of each database-in-question).
The only question in my mind at the moment is do we also copy all the comments to each tables.sql (see maintenance/tables.sql), no comments (see oracle|postgres/tables.sql) or something in the middle (see mssql/tables.sql)?
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l