On 5 April 2012 11:43, Antoine Musso hashar+wmf@free.fr wrote:
Le 04/04/12 22:56, Roan Kattouw a écrit :
<snip> >> What that means, is that a change could look fine (Verified + CR) and >> thus be merged by accident if someone with the correct right click the >> 'Submit Patch Set 1' button :-D >> >> No, that's not true. A change requires Code Review +2 before it can be > submitted, not +1. And only trusted reviewers have +2 powers.
So basically, in Gerrit, (1 + 1 != 2)...?? :-)
--HM