Dear Gerrit users,
Gerrit let us flag changes with two fields:
- Code Review
- Verified
Anyone is allowed to +1/-1 the Code Review field but only a few people
are allowed to mark a change as Verified.
I have bring back Jenkins in action and it is now running tests for us,
whenever a test suite is successful it marks it as Verified.
What that means, is that a change could look fine (Verified + CR) and
thus be merged by accident if someone with the correct right click the
'Submit Patch Set 1' button :-D
With bots squatting the Verified field and anyone able to use the Code
Review field, Gerrit has an hidden option to add an Approved status.
That could be used by the people allowed to merge.
On mediawiki/* we could end up with the following rights:
* Verified : mostly flagged by bots, eventually by human doing manual
tests for example when the change has not an automatic test case.
* Code Review : anyone can +1/-1
* Approved : used as a safeguard to prevents people with merge rights to
apply a change by mistake.
The feature is used by OpenStack:
https://review.openstack.org/
Some examples:
https://review.openstack.org/#change,6164
https://review.openstack.org/#change,6196
--
Antoine "hashar" Musso