On 10/04/2011 12:02 AM, Sumana Harihareswara wrote:
On 10/03/2011 07:19 PM, Benjamin Lees wrote:
On Mon, Oct 3, 2011 at 6:27 PM, Rob Lanphier
<robla(a)wikimedia.org> wrote:
Since a lot of people are applying,
there are quite a few to get through.
Out of curiosity, how many is "a lot" in this context?
From viewing the OTRS queue archives: 25 requests in the last 40 days.
That's about 4.3 applications per week. This is up from about 29 in the
last 60 days (3.4 apps/week), and 82 in the past 180 days (3.2
apps/week, also the rate over the entire 20 months we've been using the
OTRS queue).
I believe all these stats exclude spam.
You see why I'd like more developers reviewing commit access requests;
the more requests we get, the more time the code review takes, and I'd
like to spread that out more -- both as a TODO and as a learning
opportunity.
And -- yay for our community that we're getting more frequent commit
access requests! Along with the line on
http://toolserver.org/~robla/crstats/crstats.trunkall.html going down,
it's a sign of our development community's health and momentum.
Hmm, it looks like the web archive
http://lists.wikimedia.org/pipermail/wikitech-l/2011-October/055502.html
left out my reply and thus the statistics. :-(
To continue the rest of the thread: I recently talked with Chad, Tim and
Aaron about this thread, and about the situation regarding developer
commit access. My conclusions:
* I'm not going to add any new technical process (such as a new queue
just for extensions developers, or more granular kinds of permissions on
svn.wikimedia.org) that focuses on SVN access/process, because that's
not worth it, because we are migrating to Git this year.
* However, I am now ensuring that we are more lenient with extensions
developers than we are with people applying for core commit access. We
still, of course, watch out for security issues in submitted code samples!
* I'm also starting to explicitly encourage developers whom we're
denying core access to still work on core *in branches* and request
review. This way, they can suggest improvements via SVN (instead of
having to use Bugzilla patches) and get feedback via CR.
* I have already been reaching out to other core developers to ask them
whether I should encourage certain patch submitters to apply for commit
access. Now, I am increasing how often I privately ask other core and
extensions developers to review an applicant's code samples, and (if I
have reason to believe they've worked with the applicant) ask them
whether s/he's a reasonable person and a competent developer. Getting
someone we trust to vouch for an applicant will enhance our web of
trust, and help Chad, Tim, and Aaron decide in an applicant's favor.
I believe these steps make developer access easier to get, while still
not adding substantially more post-commit code review workload. Thanks.
--
Sumana Harihareswara
Volunteer Development Coordinator
Wikimedia Foundation