On 11-03-25 09:23 PM, Chad wrote:
On Fri, Mar 25, 2011 at 11:56 PM, Mark A. Hershberger
<mhershberger(a)wikimedia.org> wrote:
I suggest we implement this ASAP. If we start
this policy on April 4th,
we would be doing the first round of reverts April 11th. We should
grandfather in the current code, of course. It would be exempt from
grim reversion reaper, but it should still be reviewed.
I see no reason to grandfather in current code. TBH, the list of
fixmes is appalling and we should make a sprint at saying "fix
this or it'll be reverted in 24 hours" for every last one of them.
-Chad
"All" the fixmes?
What about the fixmes left open since it's not clear if anything is even
still broken currently. The fixmes for things like extra things like new
tests should be added, but the actual commit in question isn't broken in
any way. The fixmes for things which are perfectly functional, but need
a minor bit of tweaking since they work perfectly find, but don't use
the best practice methods to do it.
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [
http://daniel.friesen.name]
--
~Daniel Friesen (Dantman, Nadir-Seen-Fire) [
http://daniel.friesen.name]