Mark A. Hershberger wrote:
As Ashar pointed out this week, we've fallen
behind in code review. On
Robla's page (
http://toolserver.org/~robla/crstats/crstats.html) you can
see that commits marked “new” is beginning to edge up again.
To help with code review, Roan introduced “sign-offs” for developers who
are not as familiar with the MediaWiki code base. I'm sure he'll
correct me if I'm wrong, but I would like to encourage any developer who
isn't ready to mark code “OK” to use the sign-off feature — to indicate
that they've tested or inspected the code.
If you're running trunk in your testing or (heaven forfend!)
production, please try to see if you're exercising new code and give us
feedback by marking the sign-off as “tested”. This is one of the best
ways to get acquainted with the code base — if you miss something in
your testing, we'll be sure to let you know!
I don't currently have time for code review, but I'll try to report bugs for
all issues I encounter.
FYI I'm one of those "crazy" people running a small production website[1]
off trunk. I only update the site every few weeks, because I want to test
the changes locally before they go live, but I do read the commit messages
from mediawiki-cvs almost daily, so I know of any urgent issues.
(Small wish: it would be very helpful if every commit message referencing a
bug would also include the one-line summary of the bug; that makes it much
easier to quickly determine what the bug is about and if a bug is relevant
for a specific environment. Thanks to all developers that already add this
information!)
Of course, if you've been reviewing code, THANK
YOU and keep up the good
work.
I want to add my THANK YOU! To both developers and code reviewers: you do a
very valuable job!
Best regards
Thomas Bleher
[1]:
http://spiele.j-crew.de