2011/1/30 Brion Vibber brion@pobox.com:
I noticed a regression in the JS minification with a bit of sloppy third-party code being imported through ResourceLoader in SVGEdit:
Fixed now. The regex stripping C++-style // comments was also stripping the newline following them. I've now changed it to replace a comment plus newline (i.e. !//[^\r\n]*[\r\n]!) with a newline, so these newlines are always preserved, regardless of whether vertical whitespace stripping and collapsing is enabled.
I can work around it in the extension, but we should watch out and make sure we've got regression tests covering any cases we find.
Yes, we need minifier tests.
Roan Kattouw (Catrope)