Roan Kattouw (2011-01-21 00:50):
2011/1/21 Maciej Jarosegil@wp.pl:
Yes, I know I'm stubborn, but 6 bytes (0.6%)? Seriously? Doesn't seem convincing to me and seems like it could at least use $wgResourceLoaderMinifyJSHorizontalSpace (even if true by default).
Trevor probably didn't choose a very good test case. He also tested it on jQuery, though, and found that the unmodified version of JSPacker was faster than JSMin and produced output that was 1% larger after gzip. So in the general case, JSDistiller probably doesn't quite minify JS optimally, but the difference with JSMin is small and the difference in performance is ridiculous. That, and it doesn't present legal problems.
You've misunderstood me. As long as it's well tested and performs nicely then I'm all for (though I don't remember using MediaWiki for Evil ;-)). Great job, really. I was only hoping to have an option to fully preserve vertical space, but I've made a rotation in the name :-). So the option could be $wgResourceLoaderMinifyJSVerticalSpacePreserved or maybe $wgResourceLoaderMinifyJSPreserveEmptyLines.
Regards, Nux.