On Wed, Aug 25, 2010 at 2:39 PM, Aryeh Gregor
<Simetrical+wikilist(a)gmail.com> wrote:
On Wed, Aug 25, 2010 at 5:12 PM, lampak
<llampak(a)gmail.com> wrote:
On 25/08/10 22:45, Aryeh Gregor wrote:
> Oh, blech, FlaggedRevs reinvented the wheel and made up its own
> autopromote system. At a glance, it looks like it's hardcoded to only
> work for the editor group, so no, it can't be reused for other groups
> without some refactoring. It should really be refactored to work for
> all groups, but some of the checks are pretty expensive -- looks like
> maybeMakeEditor() in FlaggedRevs.hooks.php can run several database
> queries in some cases.
BTW, maybe they have reinvented the wheel, but
the new wheel clearly
works better.
All the more reason that it should have been implemented as
improvements to the preexisting system, so that all groups could take
advantage of it. The core system has advantages too, mainly being
much more flexible -- arbitrary anding/oring/xoring/nesting of
conditions, and easy extensibility. Plus, well, it can actually be
used for groups other than 'editor'. :)
Could someone(s) write up a design doc and put something in Bugzilla
requesting this? It seems like a sensible thing to do, but not likely
to happen without prodding.
Rob