Hello,
You are right that having "unit" and "selenium" folders in tests does not quite fit.
However, "acceptance" I don't find appropriate, either.
IMHO, Selenium actually is a framework for system testing (as it evaluates the system functionalities from a user perspective). So, how about having a folder "system"?
Regards,
Benedikt
-- Karlsruhe Institute of Technology (KIT) Institute of Applied Informatics and Formal Description Methods (AIFB)
Benedikt Kämpgen Research Associate
Kaiserstraße 12 Building 11.40 76131 Karlsruhe, Germany
Phone: +49 721 608-7946 Fax: +49 721 608-6580 Email: benedikt.kaempgen@kit.edu Web: http://www.kit.edu/
KIT - University of the State of Baden-Wuerttemberg and National Research Center of the Helmholtz Association
-----Original Message----- From: wikitech-l-bounces@lists.wikimedia.org [mailto:wikitech-l-bounces@lists.wikimedia.org] On Behalf Of Trevor Parscal Sent: Friday, August 06, 2010 8:27 PM To: wikitech-l@lists.wikimedia.org Subject: Re: [Wikitech-l] Testing Framework (was Selenium Framework - Question on coding conventions)
I think /tests/unit and /tests/acceptance would be reasonable places to put things, and if they are both within maintenance or in the root doesn't really matter to me.
Remember Selenium is a framework for doing acceptance testing, not unit testing. I don't quite see the purpose of specifying the framework name in our directory structure. Are we planning on using more than one unit or acceptance testing framework?
My 2 cents.
- Trevor
On 8/5/10 3:55 PM, Chad wrote:
On Thu, Aug 5, 2010 at 6:47 PM, Mark A. Hershbergermah@everybody.org wrote:
Markus Glaserglaser@hallowelt.biz writes:
- Where are the tests located? I suggest for core to put them into
maintenance/tests/selenium. That is where they are now. For extensions I propse a similar structure, that is<extensiondir>/tests/selenium.
Sounds fine.
In the same way, since maintenance/tests contains tests that should be run using PHPUnit, we can say that<extensiondir>/tests will contain tests that should be run using PHPUnit.
I would prefer moving them to a subdirectory of /tests/. As we hopefully amass more unit tests, keeping them in the top-level will get a bit confusing when trying to distinguish them from supporting code (shared setUp and tearDown code, the bootstrap stuff, etc)
Something like /maintenance/tests/unit/ to mirror /maintenance/tests/ selenium/ would make the most sense.
Consistency and thinking ahead is nice :)
-Chad
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l