Simetrical writes:
On 1/8/08, vasilievvv-Y8jq7F6rJ48dvk2hry9Ukdi2O/JbrIOy@public.gmane.org vasilievvv-Y8jq7F6rJ48dvk2hry9Ukdi2O/JbrIOy@public.gmane.org wrote:
Log Message:
- Add exception hooks to output pretty messages
. . .
$wgOut->addHTML( $this->getHTML() );
if( $hookResult = $this->runHooks( get_class( $this ) ) ) {$wgOut->addHTML( $hookResult );} else {$wgOut->addHTML( $this->getHTML() );}Is completely replacing all output the right way to go about generating pretty error messages? Your example more or less copy-pastes the HTML from MonoBook.php, but incompletely, which isn't good for anyone -- especially not those using non-Monobook skins. If we're going to say it should just be left ugly, okay, but if it's to be made pretty, it should use skins properly, IMO. It shouldn't just output prettier hardcoded HTML, which will look just as ugly in the context of a totally different skin and be more confusing.
People expect ugly error messages, but they don't expect error messages that are pretty but in a totally different way from the rest of the site. :)
These hooks are supposed to replace all error message. Example is just example, on the live site we should probably use the same skin as squid error message use.