Roan Kattouw wrote:
Andrew Garrett schreef:
When I did the work on Userrights, I did my best to ensure that the rights-changing code was as modular as possible (it's all abstracted into backend subroutines, which don't make any reference to the form itself). These, therefore, may be very easily moved out into wherever they should be, or you could even instantiate the Userrightsform class and call the methods on that (after making them public).
That's exactly what I did. What Brion couldn't really know is that the code in ApiChangeRights duplicated code only added to Userrights *later*. Anyway, I've re-added ApiChangeRights, which now handles disallowed groups more gracefully.
It's a bit cleaner in API terms, but I'm a bit leery of the way the functions were split up and errors returned with numerically-indexed arrays (plus I'm still very leery of having a change groups action in the API at all) so for now I've taken it back out.
-- brion vibber (brion @ wikimedia.org)