On Feb 12, 2008 4:46 PM, Simetrical Simetrical+wikilist@gmail.com wrote:
unnecessary, which now it never is anyway. So everything is correct as it stands, unless someone wants to get militant about that extra query (which should be easy to fix . . . maybe I'll do so now).
Actually, not so easy to fix, exactly, at least not if memcached is used. We're using LinkCache to fetch the article ID, so that can't be easily rolled up into the same query. Some custom code would have to be written, and it would still add a query on average unless it stored the redirect status/length/etc. in memcached too. The major effect here seems to be category links at the bottom of articles, which are the only uses of makeLinkObj() on article views I can see that are relevant (stuff like interwiki links won't run the query anyway). Maybe this part should be reverted after all, and the functionality kept only for the Parser code, unless someone wants to do some efficiency work.