After testing, flaggedrevs definitely has problems after removing the extra line. Though it does seem like it should be redundant. I'll look like into it.
Michael Daly-5 wrote:
I've been looking at the imagemap extension and noticed the following change in Imagemap_body.php:
was:
line 74 - $imageHTML = $parser->makeImage( $imageTitle, $options );
now:
line 70 - $imageHTML = $parser->makeImage( $imageTitle, $options ); line 71 - $parser->mOutput->addImage( $imageTitle->getDBkey() );
explanation in SVN:
- Have ImageMap add images to parserout like parser does. Not doing so
also causes FlaggedRevs to think the review metadata was incomplete.
However, the added line is already present at:
line 292 - # Register links line 293 - $parser->mOutput->addImage( $imageTitle->getDBkey() );
I can't see an obvious reason for the line to appear twice and it seems redundant. The change seems to have been made by Aaron. Can he or someone clarify - am I missing something?
Mike
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l