On Tue, Apr 15, 2008 at 11:16 AM, Roan Kattouw roan.kattouw@home.nl wrote:
Hmm, it appears brace style is (inadvertently) very well-observed in the API, even though I generally put the opening brace on a separate line: $ grep '^\s*{' *.php | wc -l 1 $ grep '^.*[^\s].*{' *.php | wc -l 1549
You're missing subdirectories.
$ find includes/api -iregex '^.*.(php|inc)$' -exec grep '^\s*{' {} + | wc -l 111 $ find includes/api -iregex '^.*.(php|inc)$' -exec grep '^.*[^\s].*{' {} + | wc -l 1549
Do you really feel it's necessary to use a different brace style than all of core code? The API is a part of the core software here. Not to mention variable naming conventions, etc., etc. Not that it really matters, but . . .