Platonides wrote:
http://svn.wikimedia.org/viewvc/mediawiki/branches/wikia/google-analytics/sq...
[...]
if (strcmp(name, "cookie") == 0) {Does httpHeaderGetByName already lowercase the header name? I have been looking at HttpHeader.c but didn't find anyhing that suggested so.
There is Tolower(name) call few lines earlier (line #369 in http.c)
- if (strcmp(cn, "__utma") && strcmp(cn, "__utmb") && strcmp(cn,
"__utmc") && strcmp(cn, "__utmv") && strcmp(cn, "__utmz")) { Why do you check if the cookie is exactly one of these? I'd use if (strncmp(cn, "__utm", 5) (check if the cookie name starts by __utm) or even ignore all cookies starting by _ or __
Good point. Eventually I don't want to have these cookie names hardcoded but rather specify them in the squid.conf file.
Emil