Hello all,
To add to the great work by Ori and Jon, I have my own recent pet project to announce: Reviewer-bot, which adds reviewers to any new changes uploaded to Gerrit.
The basic idea is as follows: 1) reviewer-bot listens to Gerrit's events stream 2) a contributor uploads a new change (only the first patchset is reacted upon) 3) reviewer-bot checks http://www.mediawiki.org/wiki/Git/Reviewers to see which reviewers would like to be added to new changes 4) reviewer-bot adds the reviewers to the change
Obviously, it's still in it's infancy, so it will probably crash every now and then. However, please try it by adding your gerrit username to the Reviewers page!
Of course, I also have the obligatory 'Fork me on github!'-notice: the code is available at https://github.com/valhallasw/gerrit-reviewer-bot .
I hope that, together with the RSS-based approach by Ori and the daily digest-approach by Jon, this will help to improve the Gerrit experience - especially for new developers!
Best, Merlijn
I'm not sure is that useful, because Gerrit can already notify you of new changes for any project: https://gerrit.wikimedia.org/r/#/settings/projects
What might be better is getting added as a reviewer when certain files/directories are changed (especially in mediawiki/core)
Alex
On Fri, Dec 28, 2012 at 2:12 PM, Merlijn van Deen valhallasw@arctus.nlwrote:
Hello all,
To add to the great work by Ori and Jon, I have my own recent pet project to announce: Reviewer-bot, which adds reviewers to any new changes uploaded to Gerrit.
The basic idea is as follows:
- reviewer-bot listens to Gerrit's events stream
- a contributor uploads a new change (only the first patchset is
reacted upon) 3) reviewer-bot checks http://www.mediawiki.org/wiki/Git/Reviewers to see which reviewers would like to be added to new changes 4) reviewer-bot adds the reviewers to the change
Obviously, it's still in it's infancy, so it will probably crash every now and then. However, please try it by adding your gerrit username to the Reviewers page!
Of course, I also have the obligatory 'Fork me on github!'-notice: the code is available at https://github.com/valhallasw/gerrit-reviewer-bot .
I hope that, together with the RSS-based approach by Ori and the daily digest-approach by Jon, this will help to improve the Gerrit experience - especially for new developers!
Best, Merlijn
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Alex Monk krenair@gmail.com wrote:
I'm not sure is that useful, because Gerrit can already notify you of new changes for any project: https://gerrit.wikimedia.org/r/#/settings/projects
What might be better is getting added as a reviewer when certain files/directories are changed (especially in mediawiki/core)
[...]
You can filter for those for example with the search expres- sion 'file:"^.*[pP]ost.*$"' as "Only if". Unfortunately you can't test these beforehand as the file tag is not allowed in regular searches.
Tim
That's pretty nice, Merlijn.
On Fri, Dec 28, 2012 at 8:24 PM, Tim Landscheidt tim@tim-landscheidt.dewrote:
Alex Monk krenair@gmail.com wrote:
I'm not sure is that useful, because Gerrit can already notify you of new changes for any project:
https://gerrit.wikimedia.org/r/#/settings/projects
What might be better is getting added as a reviewer when certain files/directories are changed (especially in mediawiki/core)
[...]
You can filter for those for example with the search expres- sion 'file:"^.*[pP]ost.*$"' as "Only if". Unfortunately you can't test these beforehand as the file tag is not allowed in regular searches.
Could you make it so that I can subscribe to a file pattern, too? I'd like to be added as a reviewer to all patch sets that include files with i18n in the name (unless it's a patch set by L10n-bot).
I hope that you're excluding adding people as reviewer to all patch sets by user L10n-bot, by the way...
Am 28.12.2012 20:35, schrieb Siebrand Mazeland (WMF):
Could you make it so that I can subscribe to a file pattern, too? I'd like to be added as a reviewer to all patch sets that include files with i18n in the name (unless it's a patch set by L10n-bot).
+1 I am intestered in this too.
Raimond.
(responding to Siebrand, although others have made the same points)
On 28 December 2012 20:35, Siebrand Mazeland (WMF) smazeland@wikimedia.org wrote:
That's pretty nice, Merlijn.
Thanks!
Could you make it so that I can subscribe to a file pattern, too? I'd like to be added as a reviewer to all patch sets that include files with i18n in the name (unless it's a patch set by L10n-bot).
This will take some work (because I have to retrieve the patchsets from gerrit in some way), but it should be possible. I'll try to get this working! (also for Raimond, Alex and maybe Tim)
I hope that you're excluding adding people as reviewer to all patch sets by user L10n-bot, by the way...
Initially not, but I just added an exception for L10n-bot - all it's changes will now be ignored. Thanks for mentioning this (also Matthew!)
In any case -- thanks for all the responses!
Best, Merlijn
On 29 December 2012 01:08, Merlijn van Deen valhallasw@arctus.nl wrote:
Could you make it so that I can subscribe to a file pattern, too? I'd like to be added as a reviewer to all patch sets that include files with i18n in the name (unless it's a patch set by L10n-bot).
This will take some work (because I have to retrieve the patchsets from gerrit in some way), but it should be possible. I'll try to get this working!
A (somewhat hackish, but that's the entire bot) implementation is now running - you can add a 'file_regexp' template parameter which is matched against all changed files. See [1] for examples and subscription ;-) - you can either get added to matched changes within a repository (Alex' use case) or to matched changes in all repositories (Siebrand and Raimond's use case): add yourself under the '*' header for that.
To test the regexp, try [2] (method=search, options DOTALL and IGNORECASE).
Best, Merlijn
[1] http://www.mediawiki.org/wiki/Git/Reviewers#* [2] http://re-try.appspot.com/
On 12/28/2012 07:08 PM, Merlijn van Deen wrote:
(responding to Siebrand, although others have made the same p
I hope that you're excluding adding people as reviewer to all patch sets by user L10n-bot, by the way...
Initially not, but I just added an exception for L10n-bot - all it's changes will now be ignored. Thanks for mentioning this (also Matthew!)
Thank you Could you please also exclude the owner? In other words, don't add the owner as a reviewer to their own change.
Matt Flaschen
On 2 January 2013 21:34, Matthew Flaschen mflaschen@wikimedia.org wrote:
Thank you Could you please also exclude the owner? In other words, don't add the owner as a reviewer to their own change.
Fixed!
Merlijn
On 01/02/2013 05:38 PM, Merlijn van Deen wrote:
On 2 January 2013 21:34, Matthew Flaschen mflaschen@wikimedia.org wrote:
Thank you Could you please also exclude the owner? In other words, don't add the owner as a reviewer to their own change.
Great, thank you.
Matt Flaschen
On 12/28/2012 09:12 AM, Merlijn van Deen wrote:
Hello all,
To add to the great work by Ori and Jon, I have my own recent pet project to announce: Reviewer-bot, which adds reviewers to any new changes uploaded to Gerrit.
The basic idea is as follows:
- reviewer-bot listens to Gerrit's events stream
- a contributor uploads a new change (only the first patchset is
reacted upon)
Please exclude TranslateWiki (L10n-bot). I don't think people want to be asked to review those changes, since the bot normally approves itself.
Matt Flaschen
Hi,
I just received an email from this bot, unfortunately that was undesirable. Its not necessary to cc the original author of a patch when adding a reviewer, so is the case when adding a reviewer manually.
On Friday, December 28, 2012, Merlijn van Deen wrote:
Hello all,
To add to the great work by Ori and Jon, I have my own recent pet project to announce: Reviewer-bot, which adds reviewers to any new changes uploaded to Gerrit.
The basic idea is as follows:
- reviewer-bot listens to Gerrit's events stream
- a contributor uploads a new change (only the first patchset is
reacted upon) 3) reviewer-bot checks http://www.mediawiki.org/wiki/Git/Reviewers to see which reviewers would like to be added to new changes 4) reviewer-bot adds the reviewers to the change
Obviously, it's still in it's infancy, so it will probably crash every now and then. However, please try it by adding your gerrit username to the Reviewers page!
Of course, I also have the obligatory 'Fork me on github!'-notice: the code is available at https://github.com/valhallasw/gerrit-reviewer-bot .
I hope that, together with the RSS-based approach by Ori and the daily digest-approach by Jon, this will help to improve the Gerrit experience - especially for new developers!
Best, Merlijn
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org javascript:; https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Hi Nischay,
On 29 December 2012 16:30, Nischay Nahata nischayn22@gmail.com wrote:
I just received an email from this bot, unfortunately that was undesirable. Its not necessary to cc the original author of a patch when adding a reviewer, so is the case when adding a reviewer manually.
Gerrit notifies the patch owner is someone else (in this case: reviewer-bot) adds a reviewer (in this case: me) to a patch. I'm unaware of an option to suppress these messages (and I'm also unsure whether that actually is desirable).
Best, Merlijn
wikitech-l@lists.wikimedia.org