tstarling@svn.wikimedia.org schrieb:
Revision: 25335 Author: tstarling Date: 2007-08-31 02:51:23 +0000 (Fri, 31 Aug 2007)
...
Elsewhere:
- Made most images have a border=0 attribute, instead of just images on the image description page. Does not appear to adversely affect display at all, it was just convenient.
Modified: trunk/phase3/includes/Linker.php
--- trunk/phase3/includes/Linker.php 2007-08-31 02:30:14 UTC (rev 25334) +++ trunk/phase3/includes/Linker.php 2007-08-31 02:51:23 UTC (rev 25335) @@ -566,33 +566,13 @@
}if ( isset( $fp['border'] ) ) {$imgAttribs['class'] = "thumbborder";}
It seems to me that this attribution is not added in another place, now the image option [[Image:name.jpg|100px|border|text]] is broken :-(
Raymond.
Raimond Spekking wrote:
}if ( isset( $fp['border'] ) ) {$imgAttribs['class'] = "thumbborder";}It seems to me that this attribution is not added in another place, now the image option [[Image:name.jpg|100px|border|text]] is broken :-(
Sorry, edititis. Worked in initial testing and then I broke it in a later refactor. Fixed in r25354. It's only a 1px grey border though, barely visible. I'm not sure what the point of it is.
-- Tim Starling
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Tim Starling wrote:
Raimond Spekking wrote:
}if ( isset( $fp['border'] ) ) {$imgAttribs['class'] = "thumbborder";}It seems to me that this attribution is not added in another place, now the image option [[Image:name.jpg|100px|border|text]] is broken :-(
Sorry, edititis. Worked in initial testing and then I broke it in a later refactor. Fixed in r25354. It's only a 1px grey border though, barely visible. I'm not sure what the point of it is.
IIRC as an aid for white-on-white images such as flags.
- -- brion vibber (brion @ wikimedia.org)
On 8/31/07, Tim Starling tstarling@wikimedia.org wrote:
Raimond Spekking wrote:
}if ( isset( $fp['border'] ) ) {$imgAttribs['class'] = "thumbborder";}It seems to me that this attribution is not added in another place, now the image option [[Image:name.jpg|100px|border|text]] is broken :-(
Sorry, edititis. Worked in initial testing and then I broke it in a later refactor. Fixed in r25354. It's only a 1px grey border though, barely visible. I'm not sure what the point of it is.
Also it can be customized using CSS AFAIK.
-- Tim Starling
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org http://lists.wikimedia.org/mailman/listinfo/wikitech-l
wikitech-l@lists.wikimedia.org