When I think that a version committed by myself r90650 (marked as new) is fully obsolete and already replaced in my other commit r90684 (marked as fixed)
in order to save code reviewers' time, here are my questions:
1. shall I revert the 90650 from SVN ? 2. how exactly, and what would be meaingful comment ? 3. or can I do anything else which is of help in this case?
I need to ask here, because I could not find clear instructions or conventions for such cases on http://www.mediawiki.org/wiki/Code_review_guide and http://www.mediawiki.org/wiki/Subversion
T.
Ashar Voultoiz wrote:
On 24/06/11 08:33, Thomas Gries wrote:
When I think that a version committed by myself r90650 (marked as new) is fully obsolete and already replaced in my other commit r90684 (marked as fixed)
I would say, if it is reverted, mark it reverted :)
Or maybe resolved, if it's just rewritten. It's true that no status seems to fit this exact case.
Am 27.06.2011 23:16, schrieb Platonides:
Ashar Voultoiz wrote:
When I think that a version committed by myself r90650 (marked as new) is fully obsolete and already replaced in my other commit r90684 (marked as fixed) I would say, if it is reverted, mark it reverted :)
Or maybe resolved, if it's just rewritten. It's true that no status seems to fit this exact case.
Moreover, I as the committer may only assign "new" when strictly following the http://www.mediawiki.org/wiki/Code_review_guide :
"Please do not change the flags for your own revisions, except to change them back to "new" after you fix a revision that was flagged "fixme."
wikitech-l@lists.wikimedia.org