This has been happening since Saturday. Looking for resolution.
Empty patch to demonstrate: https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/600431
Last merged patch (passed test, insignificant change to php): https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/596512
Failure: https://integration.wikimedia.org/ci/job/mwskin-php72-phan-seccheck-docker/5...
Error:
TypeError: Argument 1 passed to PreTaintednessVisitor::linkParamAndFunc() must be an instance of Phan\Language\Element\Variable, instance of Phan\Language\Element\Property given, called in /opt/phan/vendor/mediawiki/phan-taint-check-plugin/src/PreTaintednessVisitor.php on line 147 and defined in /opt/phan/vendor/mediawiki/phan-taint-check-plugin/src/TaintednessBaseVisitor.php:1093Stack trace:#0 /opt/phan/vendor/mediawiki/phan-taint-check-plugin/src/PreTaintednessVisitor.php(147): PreTaintednessVisitor->linkParamAndFunc(Object(Phan\Language\Element\Property), Object(Phan\Language\Element\Method), 0)#1 /opt/phan/vendor/mediawiki/phan-taint-check-plugin/src/MWPreVisitor.php(40): PreTaintednessVisitor->visitMethod(Object(ast\Node))
...
Aron
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
On 2020-06-01 07:21, Aron Demian wrote:
This has been happening since Saturday. Looking for resolution.
See https://phabricator.wikimedia.org/T254079. It's currently being fixed by rolling out a new version of the phan-taint-check plugin.
- -- Legoktm
Thank you!
And thanks to Daimona Eaytoy and DannyS712 for the temporary patch, it is working now!
On Mon, 1 Jun 2020 at 21:40, Kunal Mehta legoktm@member.fsf.org wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
On 2020-06-01 07:21, Aron Demian wrote:
This has been happening since Saturday. Looking for resolution.
See https://phabricator.wikimedia.org/T254079. It's currently being fixed by rolling out a new version of the phan-taint-check plugin.
- -- Legoktm
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE+h6fmkHn9DUCyl1jUvyOe+23/KIFAl7VWYcACgkQUvyOe+23 /KKwuhAAo5coaZqhKgidTfFA3DgCZ4ImUK2/wTApuN23c+NXR79qEiGr/hbz3/UN oJrXZOrXVmeB9JBGu8Evm6PA8OpjAb4DaMqnec3kfUIMZJUOuQf6s/02298p3Z2t u/71UZuzRfwuHYfULUBBi7PXlXXd2EZvJEcE6xPvxIlDP+o1QO8jI+I25slgim/f Z/S24TgvbOc/GMccJfBajl5AfluCLuSYhRV3tE2Is1fwquZLbFndtJyBa4nW0uaw dUDrq2l5EVAin3D2nEw7S4OLWqpB6nrIUQ2zN/Cu9fhnHFv4rFmPlUPEkK1xv5Xp cgyCiEWseJZNhsQzO2jjO3q9A7QJFh5v+OXJy3DMwwYQMjS2cwOdzR+XNrKcEnP5 mm9UvDCbh2qsMALCGTfHFznt23KbPkbnYxc1CKG7kIYHOPL2+KSS9zl910H08tIt lvsLqdrk+36M59H4a1QDKuZuYnJ954zg4kRUJd6IaIle92DOE+oE8t59F4mH8BRV FgybziwiOOvO/XqIRNF6LMkr4X/ewqTtKJP/zVzEodG1o55IFKZuz/Gho2TCstm3 rweBBX+rdAgwJnAuHxNX4bcGd7sSv2rUgrJ76fBSgtrF5sKdrCldwbU0ulMLpLyJ iCrWo14IOV+VevyEtYI/mGX24XO5DOCpOq7uxSYZjNLnbZB3h6U= =1BI5 -----END PGP SIGNATURE-----
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
wikitech-l@lists.wikimedia.org