Hi jojo,
It do not really get this change. You change the help page handling from maintainable inside the wiki to a configuration file. And there you use a non-default interwiki code (mw: is not present in interwiki.sql. "mediawikiwiki:" points to www.mediawiki.org). This means that a default MediaWiki installation will not have a proper link to the help page. It will also no longer facilitate localisation of the help page URL.
I am not sure this is an improvement... I suggest you change it back and replace 'coll-helppage' to "mediawikiwiki:Extension:Collection/Help". I will set the message to 'optional' so that translators will not localise it, unless there is a need for it (for example because "mediawikiwiki:Extension:Collection/Help" was translated). This ensure a proper implementation of i18n and possibilities for L10n remain. Wiki sysops will also still be able to change the documentation link and there is is sufficient guarantee ensure that the doc link initially points where you want it to point.
It may of course be that you have a different reason for changing the help page, and if so, please explain...
Cheers! Siebrand
-----Oorspronkelijk bericht----- Van: mediawiki-cvs-bounces@lists.wikimedia.org [mailto:mediawiki-cvs-bounces@lists.wikimedia.org] Namens jojo@mayflower.knams.wikimedia.org Verzonden: vrijdag 13 juni 2008 16:00 Aan: mediawiki-cvs@lists.wikimedia.org Onderwerp: [MediaWiki-CVS] SVN: [36258] trunk/extensions/Collection
Revision: 36258 Author: jojo Date: 2008-06-13 14:00:01 +0000 (Fri, 13 Jun 2008)
Log Message: ----------- changed help page handling
Modified Paths: -------------- trunk/extensions/Collection/Collection.body.php trunk/extensions/Collection/Collection.i18n.php trunk/extensions/Collection/Collection.php
Modified: trunk/extensions/Collection/Collection.php =================================================================== --- trunk/extensions/Collection/Collection.php 2008-06-13 13:22:50 UTC (rev 36257) +++ trunk/extensions/Collection/Collection.php 2008-06-13 14:00:01 UTC (rev 36258) @@ -55,6 +55,9 @@ /** Template blacklist article */ $wgPDFTemplateBlacklist = 'MediaWiki:PDF Template Blacklist';
+/** Help page for the Collection extension */ $wgCollectionHelpPage = +'mw:Extension:Collection/Help';
Hi Siebrand!
Am 13.06.2008 um 16:12 schrieb Siebrand Mazeland:
It do not really get this change.
The idea behind the change was that we want to achieve almost zero- configuration for the Collection extension. In particular, administrators do not have to care about the help page if they don't want to use a custom help page, but if they care, they can provide one.
You change the help page handling from maintainable inside the wiki to a configuration file.
Although it's configurable via a global variable, it has a sensible default, so it's optional. Well, maybe the default was not so sensible, as you point out ^_^:
And there you use a non-default interwiki code (mw: is not present in interwiki.sql. "mediawikiwiki:" points to www.mediawiki.org).
OK, that was my fault. I googled for the interwiki code of mediawiki.org and *somewhere* (it was some "official" site, but I don't remember which one exactly) saw the code "mw" for mediawiki.org in a table with other interwiki codes, which obviously was just wrong or outdated. I'd change that to "mediawikiwiki" as soon as we have an agreement on the general help page handling.
It will also no longer facilitate localisation of the help page URL.
Isn't configuration via LocalSettings.php and $wgCollectionHelpPage sufficient for localisation, too?
I am not sure this is an improvement... I suggest you change it back and replace 'coll-helppage' to "mediawikiwiki:Extension:Collection/ Help". I will set the message to 'optional' so that translators will not localise it, unless there is a need for it (for example because "mediawikiwiki:Extension:Collection/Help" was translated).
If I understand correctly this would effectively inhibit the configuration of a custom help page which is stored in the local MediaWiki, at least without adjusting Collection.i18n.php.
As I understand it, Collection.i18n.php shouldn't be used for configuration purposes or shouldn't need to be touched by an administrator who is merely using the extension, not modifying it.
If my changes were complete nonsense I'll revert them :-)
I'm open to any suggestions!
Thanks and regards, Jojo
wikitech-l@lists.wikimedia.org