Scribunto has an option to allow code to be saved even if it contains syntax errors that prevent it from ever working. The original reason for this feature was to make it more convenient to save incomplete code. However, in practice, this has never been used for its intended purpose, and users who don't know any Lua are breaking otherwise-functional modules with it. Because of this, and because it's easy enough to save incomplete code by simply wrapping it all in a multiline comment, I plan to remove the option unless objections are raised.
Jackmcbarn
On 28 September 2014 20:17, Jackmcbarn jackmcbarn@gmail.com wrote:
Scribunto has an option to allow code to be saved even if it contains syntax errors that prevent it from ever working. The original reason for this feature was to make it more convenient to save incomplete code. However, in practice, this has never been used for its intended purpose, and users who don't know any Lua are breaking otherwise-functional modules with it. Because of this, and because it's easy enough to save incomplete code by simply wrapping it all in a multiline comment, I plan to remove the option unless objections are raised.
This seems totally reasonable; we already do this with JSON, and I believe it's also planned for JS and CSS content types as well. Go for it.
J.
Just for info the gerrit change: https://gerrit.wikimedia.org/r/#/c/160367/
Freundliche Grüße / Kind regards Florian
-----Ursprüngliche Nachricht----- Von: wikitech-l-bounces@lists.wikimedia.org [mailto:wikitech-l-bounces@lists.wikimedia.org] Im Auftrag von James Forrester Gesendet: Montag, 29. September 2014 19:38 An: Wikimedia developers Betreff: Re: [Wikitech-l] Removal of Scribunto's "Allow saving code with errors" option
On 28 September 2014 20:17, Jackmcbarn jackmcbarn@gmail.com wrote:
Scribunto has an option to allow code to be saved even if it contains syntax errors that prevent it from ever working. The original reason for this feature was to make it more convenient to save incomplete code. However, in practice, this has never been used for its intended purpose, and users who don't know any Lua are breaking otherwise-functional modules with it. Because of this, and because it's easy enough to save incomplete code by simply wrapping it all in a multiline comment, I plan to remove the option unless objections are raised.
This seems totally reasonable; we already do this with JSON, and I believe it's also planned for JS and CSS content types as well. Go for it.
J. -- James D. Forrester Product Manager, Editing Wikimedia Foundation, Inc.
jforrester@wikimedia.org | @jdforrester _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
+1
On Sep 29, 2014, at 19:38 , James Forrester jforrester@wikimedia.org wrote:
On 28 September 2014 20:17, Jackmcbarn jackmcbarn@gmail.com wrote:
Scribunto has an option to allow code to be saved even if it contains syntax errors that prevent it from ever working. The original reason for this feature was to make it more convenient to save incomplete code. However, in practice, this has never been used for its intended purpose, and users who don't know any Lua are breaking otherwise-functional modules with it. Because of this, and because it's easy enough to save incomplete code by simply wrapping it all in a multiline comment, I plan to remove the option unless objections are raised.
This seems totally reasonable; we already do this with JSON, and I believe it's also planned for JS and CSS content types as well. Go for it.
J.
James D. Forrester Product Manager, Editing Wikimedia Foundation, Inc.
jforrester@wikimedia.org | @jdforrester _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
As a note, this has been merged and will go out with wmf2; I've added it to Tech/News 41.
J.
On 29 September 2014 23:37, dan entous dan.entous.wikimedia@gmail.com wrote:
+1
On Sep 29, 2014, at 19:38 , James Forrester jforrester@wikimedia.org wrote:
On 28 September 2014 20:17, Jackmcbarn jackmcbarn@gmail.com wrote:
Scribunto has an option to allow code to be saved even if it contains syntax errors that prevent it from ever working. The original reason for this feature was to make it more convenient to save incomplete code. However, in practice, this has never been used for its intended purpose, and users who don't know any Lua are breaking otherwise-functional
modules
with it. Because of this, and because it's easy enough to save
incomplete
code by simply wrapping it all in a multiline comment, I plan to remove
the
option unless objections are raised.
This seems totally reasonable; we already do this with JSON, and I
believe
it's also planned for JS and CSS content types as well. Go for it.
J.
James D. Forrester Product Manager, Editing Wikimedia Foundation, Inc.
jforrester@wikimedia.org | @jdforrester _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
So how much broken Lua is out there in the wild on WMF wikis?
On 29 September 2014 01:17, Jackmcbarn jackmcbarn@gmail.com wrote:
Scribunto has an option to allow code to be saved even if it contains syntax errors that prevent it from ever working. The original reason for this feature was to make it more convenient to save incomplete code. However, in practice, this has never been used for its intended purpose, and users who don't know any Lua are breaking otherwise-functional modules with it. Because of this, and because it's easy enough to save incomplete code by simply wrapping it all in a multiline comment, I plan to remove the option unless objections are raised.
Jackmcbarn _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Very little. Currently, enwiki has one broken module [ https://en.wikipedia.org/wiki/Category:Scribunto_modules_with_errors] and dewiki has none [ https://de.wikipedia.org/wiki/Kategorie:Wikipedia:Modul_mit_Syntaxfehler].
On Mon, Sep 29, 2014 at 2:16 PM, David Gerard dgerard@gmail.com wrote:
So how much broken Lua is out there in the wild on WMF wikis?
On 29 September 2014 01:17, Jackmcbarn jackmcbarn@gmail.com wrote:
Scribunto has an option to allow code to be saved even if it contains syntax errors that prevent it from ever working. The original reason for this feature was to make it more convenient to save incomplete code. However, in practice, this has never been used for its intended purpose, and users who don't know any Lua are breaking otherwise-functional
modules
with it. Because of this, and because it's easy enough to save incomplete code by simply wrapping it all in a multiline comment, I plan to remove
the
option unless objections are raised.
Jackmcbarn _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
wikitech-l@lists.wikimedia.org