So, developers and people tracking CVS will have noted that I've added event-hooking facilities to MediaWiki. There's a framework for adding hooks to events, documentation, and a sample extension that uses event hooks to log events to the syslog facility. I plan to keep adding events to the codebase (and event hooks to the Syslog extension) over the next few days as I think of them and figure out how to implement them.
I think that RC patrol would be a stellar example of a feature that should be implemented using event hooks. First, it's optional. Second, the enabling code for it is spread over several different functions in several different modules -- it would be more comprehensible and maintainable if it were all consolidated in one place. Finally, it's reactive to "core" events like saving and viewing articles.
My question: would anyone be freaked out if I migrated RC patrol to a single module using event hooks? I'm not 100% sure it can be done, but I think it would be a worthwhile exercise.
~ESP
On Mon, 2004-29-11 at 16:52 +1100, Tim Starling wrote:
Evan Prodromou wrote:
My question: would anyone be freaked out if I migrated RC patrol to a single module using event hooks? I'm not 100% sure it can be done, but I think it would be a worthwhile exercise.
After 1.4, or in a separate branch.
Why?
~ESP
Evan Prodromou wrote:
On Mon, 2004-29-11 at 16:52 +1100, Tim Starling wrote:
Evan Prodromou wrote:
My question: would anyone be freaked out if I migrated RC patrol to a single module using event hooks? I'm not 100% sure it can be done, but I think it would be a worthwhile exercise.
After 1.4, or in a separate branch.
Why?
Because we plan to have a 1.4 beta out within a few days. No more experimental code for now, please. It's hard enough getting the existing new features ready.
-- Tim Starling
On Tue, 30 Nov 2004 09:17:35 +1100, Tim Starling t.starling@physics.unimelb.edu.au wrote:
After 1.4, or in a separate branch.
Why?
Because we plan to have a 1.4 beta out within a few days. No more experimental code for now, please. It's hard enough getting the existing new features ready.
Would it not therefore make sense to create a seperate branch for 1.4, to seperate out the features that should be in that release? I'm thinking not only about HEAD still being available for experiments (like Evan's), but that certain features already committed will probably want *backing out* of the code, as being too immature to include in 1.4, or incomplete enough that their inclusion makes it hard to stabilise the 1.4 beta. If they're still there in HEAD, they can be added back in once they're a bit more stable, and potentially still be part of the 1.4 release, or a point release shortly after.
wikitech-l@lists.wikimedia.org